Skip to content

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Apr 9, 2025

🎉 New feature

Adds CI testing for feature added in #1491

Summary

The ability to build python bindings separately from the core library was added in #1491 and is currently used when building the homebrew formulae but is not directly tested in CI. This adds a quick test to the Ubuntu GitHub actions workflow to compile the python bindings after compiling example code.

Test it

Verify the Ubuntu GitHub actions workflow succeeds

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@scpeters scpeters requested a review from azeey as a code owner April 9, 2025 20:28
@github-actions github-actions bot added 🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty labels Apr 9, 2025
@scpeters scpeters changed the title Test building python bindings in CI Test building python bindings in Ubuntu CI Apr 9, 2025
@github-project-automation github-project-automation bot moved this from Inbox to In review in Core development Apr 9, 2025
@scpeters scpeters merged commit ff26247 into sdf15 Apr 9, 2025
18 checks passed
@scpeters scpeters deleted the scpeters/ci_build_python_bindings branch April 9, 2025 22:53
@github-project-automation github-project-automation bot moved this from In review to Done in Core development Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏛️ ionic Gazebo Ionic 🪵 jetty Gazebo Jetty

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants